*: move util as a component #4504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jay Lee <busyjaylee@gmail.com>
BusyJay
added
type/enhancement
|
how about the rebuild time now? |
|
No notable changes detected. But building channel benchmark is much faster than before now. |
|
Good job. |
breezewish
previously approved these changes
Apr 10, 2019
|
(related #3352) |
brson
requested changes
Apr 10, 2019
Signed-off-by: Jay Lee <busyjaylee@gmail.com>
Signed-off-by: Jay Lee <busyjaylee@gmail.com>
Signed-off-by: Jay Lee <busyjaylee@gmail.com>
|
please fix the conflicts @BusyJay |
kennytm
added
status/LGT2
Signed-off-by: Jay Lee <busyjaylee@gmail.com>
siddontang
approved these changes
Apr 12, 2019
breezewish
approved these changes
Apr 12, 2019
sticnarf
pushed a commit
to sticnarf/tikv
that referenced
this pull request
Oct 27, 2019
Signed-off-by: Jay Lee <busyjaylee@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have you changed? (mandatory)
Extract util module from the TiKV sources to a standalone sub-project. It's part of process to speed up compilation by reducing code inside TiKV projects.
What are the type of the changes? (mandatory)
How has this PR been tested? (mandatory)
unit tests
Does this PR affect documentation (docs) update? (mandatory)
No.
Does this PR affect tidb-ansible update? (mandatory)
No.
Refer to a related PR or issue link (optional)
#4165